Fix wasm table access when accessing functions in splitted module #25432
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use the `toIndexType` utility function to access the wasm table
sbc100
reviewed
Sep 30, 2025
Changes from comments
sbc100
reviewed
Sep 30, 2025
src/preamble.js
Outdated
| return wasmTable.get(toIndexType(1 + parseInt(prop)))(...args); | ||
| #else | ||
| return wasmTable.get(toIndexType(prop))(...args); | ||
| prop = 1 + parseInt(prop) |
There was a problem hiding this comment.
nit: add a semicolon at end of line.
This seems to be the case. |
|
lgtm with the test update |
|
Can you update the test ? |
Sure, do you mean increasing the coverage of the |
|
While working on split_module + mem64 in my application, I notice more changes required on top of this PR. I'm working on resolving those issues as well |
|
Yes, I was hoping you can add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing functions from the splitted module, there's an error because the wasmtable is using table64. So we would have to access it with a BigInt. This has been updated in other part of the codebase, but we missed this file.